[vlc-devel] ffmpeg r10621 breaks on MacOSX (Intel)
jean-paul.saman at planet.nl
Tue Oct 16 09:38:01 CEST 2007
Enrique Osuna wrote:
> Resending patch. Forgot to include -R switch when applying patch to ffmpeg.
> On 10/13/07, Enrique Osuna <enrique.osuna at gmail.com> wrote:
>> Attached patch is a work around to a problem introduced in ffmpeg r10621.
>> It's associated with new assembly code in ffmpeg/i386/dsputils_mmx.c file.
>> The file should compile, but there is a bug with gcc. This patch will
>> revert dsputils_mmx.c to the last known good (where gcc won't error out).
>> I'll try to bring it up to ffmpeg dev team.
It looks like this patch is removing support for SSE2 which is probably
needed for Windows. Isn't it a better idea to split the patch up in a
windows specific part and MacOSX specific part? And then modify
extras/contrib/src/Makefile to only apply the windows part when
compiling for Windows. The same counts for the MacOSX part to only apply
when compiling for Mac.
More information about the vlc-devel