[vlc-devel] ffmpeg r10621 breaks on MacOSX (Intel)

[Enrique Osuna]

If you look where the patch applies some changes to the Makefile it checks
to see if its being compiled under Darwin (codename for MacOSX).  If it is,
then the libavcodec is reverted to its last known good...otherwise it will
compile with the SSE code.

Attached is an updated version of the patch, it should be a little cleaner.
I've tested it several times and it works fine.

Enrique


On 10/16/07, Jean-Paul Saman <jean-paul.saman at planet.nl> wrote:
>
> Enrique Osuna wrote:
> > Resending patch.  Forgot to include -R switch when applying patch to
> ffmpeg.
> >
> > Enrique
> >
> > On 10/13/07, Enrique Osuna <enrique.osuna at gmail.com> wrote:
> >> Attached patch is a work around to a problem introduced in ffmpeg
> r10621.
> >> It's associated with new assembly code in ffmpeg/i386/dsputils_mmx.c
> file.
> >> The file should compile, but there is a bug with gcc.  This patch will
> >> revert dsputils_mmx.c to the last known good (where gcc won't error
> out).
> >>
> >> I'll try to bring it up to ffmpeg dev team.
>
> It looks like this patch is removing support for SSE2 which is probably
> needed for Windows. Isn't it a better idea to split the patch up in a
> windows specific part and MacOSX specific part? And then modify
> extras/contrib/src/Makefile to only apply the windows part when
> compiling for Windows. The same counts for the MacOSX part to only apply
> when compiling for Mac.
>
> Gtz,
> Jean-Paul Saman.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20071016/f06268bc/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extra-contrib-src-makefile-for-ffmpeg.patch
Type: application/octet-stream
Size: 18156 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20071016/f06268bc/attachment.obj>