[vlc-devel] vlc: svn commit r21658 (funman)

[Rémi Denis-Courmont]

Le samedi 1 septembre 2007, Subversion daemon a écrit :
> r21658 | funman | 2007-09-01 16:09:58 +0200 (Sat, 01 Sep 2007) | 1
> line Changed paths:
>    M /trunk/modules/control/rc.c
>
> rc: non blocking input read
>

What is this supposed to achieve:

     /* Connection closed */
-    if( i_read <= 0 )
+    if( i_read < 0 )


???????

And why do you reimplement net_Read on top of net_Read? It already has a 
timeout. Hint: net_Read *ALREADY* checks b_die !!!!

And this will not work on Windows (cannot poll STDIN on Windows).

This entire commit looks completely nonsensical to me.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070901/58fa3c51/attachment.sig>