[vlc-devel] vlc: svn commit r21658 (funman)

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Rémi Denis-Courmont a écrit :
> Le samedi 1 septembre 2007, Subversion daemon a écrit :
>> r21658 | funman | 2007-09-01 16:09:58 +0200 (Sat, 01 Sep 2007) | 1
>> line Changed paths:
>>    M /trunk/modules/control/rc.c
>>
>> rc: non blocking input read
>>
> 
> What is this supposed to achieve:
> 
>      /* Connection closed */
> -    if( i_read <= 0 )
> +    if( i_read < 0 )
> 
> 
> ???????

Prevents the interface to die when no data has been read, but it won't
happen since we stay in the while() loop.

> 
> And why do you reimplement net_Read on top of net_Read? It already has a 
> timeout. Hint: net_Read *ALREADY* checks b_die !!!!
> 

i should have read net_Read() better and see it uses poll() already.

net_Read() checks b_die, but doesn't check ->p_libvlc->b_die, and so it
won't return when quit is requested by another module.

I don't know what is the correct way to go here.

> And this will not work on Windows (cannot poll STDIN on Windows).
> 

i saw that on buildbot

> This entire commit looks completely nonsensical to me.

i reverted it
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel


- --
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG2XvzYWCeGMCv8Q8RAv2bAKCuuBD7boI2wl7eOPy+d+6R3VYfGQCg20Tp
itkLFESyCe0goAjYbZRUX6Y=
=xL2i
-----END PGP SIGNATURE-----