[vlc-devel] Patches to add support for speex codec in RTP

[Hawkins, William - AES]

Yeah, it was not the *best* of ideas. Fortunately all of the other conditional statements around i_extra check for > 0 rather than !0. So, it was an easy change. I will make your suggested change and resubmit the patches once I get additional feedback. I don't want to SPAM the list with too many revisions.

Thanks for your initial feedback.
Will


-----Original Message-----
From: vlc-devel-bounces at videolan.org on behalf of Laurent Aimar
Sent: Fri 9/7/2007 9:42 AM
To: Mailing list for VLC media player developers
Subject: Re: [vlc-devel] Patches to add support for speex codec in RTP
 
Hi,

On Fri, Sep 07, 2007, Hawkins, William - AES wrote:
> es_out.c: I used a -1 value for the i_extra field of the es_format_t structure to indicate that the Speex audio originated from an RTP stream. The modifications here ensure that a value of -1 does not start a deep copy of the data pointed to by p_extra. 

 I am really against using -1 in such a field. It will introduce many bugs.

You should simply use another fourcc code for speex over RTP or you may
convert it back to normal speex format if possible in live555.cpp.

Regards,

-- 
fenrir

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
http://mailman.videolan.org/listinfo/vlc-devel


*****************************************************************
This e-mail and any files transmitted with it may be proprietary 
and are intended solely for the use of the individual or entity to 
whom they are addressed. If you have received this e-mail in 
error please notify the sender. Please note that any views or
opinions presented in this e-mail are solely those of the author 
and do not necessarily represent those of ITT Corporation. The 
recipient should check this e-mail and any attachments for the 
presence of viruses. ITT accepts no liability for any damage 
caused by any virus transmitted by this e-mail.
*******************************************************************

-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 3494 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070907/b6b55c8e/attachment.bin>