[vlc-devel] Patches to add support for speex codec in RTP

[Hawkins, William - AES]

I have modified the comments in speex.c and attached the updated patch file to the ticket I created in the trac system.

I don't understand your question regarding speex frame boundaries. Please ask again and I will do my best to answer. I believe that the draft-ietf-avt-rtp-speex may change. However, I do not believe that it will change in a way that significantly impacts this patch. Moreover, the code that would be affected by changes to the draft are confined to rtp.c and speex.c. The demux code would not need to change. 

I look forward to your continued comments. 
Will


-----Original Message-----
From: Rémi Denis-Courmont [mailto:rem at videolan.org]
Sent: Thu 9/13/2007 11:50 AM
To: Hawkins, William - AES; vlc-devel at videolan.org
Cc: chris.robson at nrl.navy.mil
Subject: Re: [vlc-devel] Patches to add support for speex codec in RTP
 

	Hello,

Le Wednesday 12 September 2007 23:10:56 Hawkins, William - AES, vous avez 
écrit :
> I took the community response and modified my patches. I no longer use
> i_extra =(=) -1 as a means to signal the codec that RTP is in use.

You should have fixed the comment accordingly.

> Also, the hard-coded value of 8000 is no longer present. These patches only
> affect src/audio_output/dec.c,

Not skilled to comment on this one.

> modules/codec/speex.c,

Maybe a bit too verbose debug for real life use?

> modules/demux/live555.cpp

Ok by me.

> and modules/stream_out/rtp.c. 

It is still possible to detect Speex frames boundaries at that point? If it 
is, you obey by the maximum packet size (id->i_mtu - 12). If not, I don't 
really know.

A meta issue concern your estimation of the risk that draft-ietf-avt-rtp-speex 
evolves in a non-compatible manner?


Best regards,

-- 
Rémi Denis-Courmont
http://www.remlab.net/

*****************************************************************
This e-mail and any files transmitted with it may be proprietary 
and are intended solely for the use of the individual or entity to 
whom they are addressed. If you have received this e-mail in 
error please notify the sender. Please note that any views or
opinions presented in this e-mail are solely those of the author 
and do not necessarily represent those of ITT Corporation. The 
recipient should check this e-mail and any attachments for the 
presence of viruses. ITT accepts no liability for any damage 
caused by any virus transmitted by this e-mail.
*******************************************************************