[vlc-devel] vlc: svn commit r22246 (courmisch)

[Rémi Denis-Courmont]

Le Wednesday 26 September 2007 19:37:36 Rafaël Carré, vous avez écrit :
> Rémi Denis-Courmont a écrit :
> > Le Sunday 23 September 2007 19:16:24 Subversion daemon, vous avez écrit :
> >> r22246 | courmisch | 2007-09-23 18:16:23 +0200 (Sun, 23 Sep 2007) | 3
> >> lines Changed paths:
> >>    M /trunk/src/playlist/loadsave.c
> >>
> >> Re-do [18770] - fixes #1287.
> >> And why the heck was this undone in the first place??
>
> You'll note that [21574] message says:
> "Uses --no-media-library if you don't want to use it (see #1047)"

Adding some-semi-secret (even I did not know about it) command line option is 
not satisfactory.

> > There is something really wrong when someone with commit access simply
> > undoes fixes. This commit even had the associated Trac ticket number
> > detailling the problem. Thank you big time for wasting my time in
> > tracking down trivially avoidable but well hidden regressions.
>
> Is removing code a 'fix' ? I don't think so.

Removing buggy feature code is a fix, I do think so.

-- 
Rémi Denis-Courmont
http://www.remlab.net/