[vlc-devel] [patch] ensure p_pic->pf_release calls are performed carefuly

[Anthony Loiseau]

I have crossed a segmentation fault with a not protected call to
"p_pic->pf_release()" (video_filter/deinterlace.c:2185).

Most of those calls are already protected by "if( p_pic->pf_release )",
this patch ensure the test to be performed before all calls to
p_pic->pf_release().


NB:
As dionea as pointed on IRC, a more efficient solution would be to
provide a default implementation for pf_release.
I have tried to have a default value for pf_release to point an empty
method but not succedded in this way, feel free to go to this way.
NB2: 
p_pic is of type picture_t, defined in include/vlc_vout.h (~line 60)


regards,
Anthony Loiseau
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-protect-p_pic-pf_release-calls-over-segfault.patch
Type: application/mbox
Size: 13741 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080408/9f203ab3/attachment.mbox>