[vlc-devel] [patch] ensure p_pic->pf_release calls are performed carefuly

Rémi Denis-Courmont rem at videolan.org
Mon Apr 14 15:14:58 CEST 2008

Le mardi 8 avril 2008, Anthony Loiseau a écrit :
> I have crossed a segmentation fault with a not protected call to
> "p_pic->pf_release()" (video_filter/deinterlace.c:2185).
> Most of those calls are already protected by "if( p_pic->pf_release
> )", this patch ensure the test to be performed before all calls to
> p_pic->pf_release().

Do we know which plugins fail to set the callback? (and if it makes much 
sense not to set the callback except in some really corner cases).

I suspect this is yet another attempt to use an object before it's been 
initialized. If that is the case, checking for pf_release NULL-ity will 
not fix the problem - merely hide it in some cases.

Rémi Denis-Courmont

More information about the vlc-devel mailing list