[vlc-devel] commit: when releasing vlm, clear all media (Filippo Carone )

Filippo Carone filippo at carone.org
Wed Apr 9 11:57:28 CEST 2008


Pierre d'Herbemont ha scritto:
> On Apr 9, 2008, at 11:32 AM, Pierre d'Herbemont wrote:
>   
>> On Apr 9, 2008, at 10:14 AM, Filippo Carone wrote:
>>     
>>> If you are confident about moving the clear_medias inside the
>>> vlm_delete, it's ok for me.
>>>       
>> More in the vlm's Destructor... But yes, that's what should be done
>> IMO. I'll do it.
>>     
>
> In fact, it's already done. It means that there is a bug somewhere  
> else. We have to remove your fix, as it hides that precise bug...
>
>   

IMHO currently, from a libvlc point of view, the code in 
libvlc_vlm_release is correct and shouldn't be reverted, since the 
release function releases all resources correctly. Before reverting we 
should check what happens in other modules using vlm_Delete.

Cheers,
Filippo




More information about the vlc-devel mailing list