[vlc-devel] commit: when releasing vlm, clear all media (Filippo Carone )
pdherbemont at free.fr
Wed Apr 9 12:14:07 CEST 2008
On Apr 9, 2008, at 11:57 AM, Filippo Carone wrote:
> Pierre d'Herbemont ha scritto:
>> On Apr 9, 2008, at 11:32 AM, Pierre d'Herbemont wrote:
>>> On Apr 9, 2008, at 10:14 AM, Filippo Carone wrote:
>>>> If you are confident about moving the clear_medias inside the
>>>> vlm_delete, it's ok for me.
>>> More in the vlm's Destructor... But yes, that's what should be done
>>> IMO. I'll do it.
>> In fact, it's already done. It means that there is a bug somewhere
>> else. We have to remove your fix, as it hides that precise bug...
> IMHO currently, from a libvlc point of view, the code in
> libvlc_vlm_release is correct
Well, it's redundant, but I do see your point and nearly agree, but...
> and shouldn't be reverted, since the
> release function releases all resources correctly. Before reverting we
> should check what happens in other modules using vlm_Delete.
... given that this hides a bug from our embryonic test suite, that's
no point to simply work around the bug.
(hiding a bug can't be the right thing)
Sorry about reverting that fast.
More information about the vlc-devel