[vlc-devel] commit: small rebert for i_length, enables to get meta itags from mp4 again . (Ilkka Ollakka )

Rafaël Carré funman at videolan.org
Sat Apr 12 15:01:21 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Sat, 12 Apr 2008 10:43:52 +0300,
Ilkka Ollakka <ilkka.ollakka+vlc at oamk.fi> a écrit :

> On la 12. huhtikuuta 2008 01:00:40, Rafaël Carré wrote:
> > The correct fix (according to courmisch's commit) seems to use
> > if( i_length > 1 ) to me then, because you'll miss 1 character if
> > the tags are not set by apple stuff.
> 
> Actually no, because earlier (before courmisch commit), there was
> comparation like
> if( i_length > i_read )
> and now it's 
> if( i_length >= i_read )
> 
> so allready that one sorts out that off-by-one and adding one
> shouldn't be needed to get all characters.
> 

ok

- -- 
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIALKjYWCeGMCv8Q8RAm/CAJ4nWA7J6Tnqd9PenjHPnPa+X6RNZgCfSTfM
lKgKVyRoOROe2zlub0z3nvI=
=an0b
-----END PGP SIGNATURE-----


More information about the vlc-devel mailing list