[vlc-devel] [PATCH] autocrop video filter 2
Antoine Cellerier
dionoea at videolan.org
Tue Apr 15 11:16:19 CEST 2008
A few more comments (I haven't had the opportunity to test the patch
yet).
On Mon, Apr 14, 2008, Geoffroy Couprie wrote:
> + add_shortcut( "autocrop" );
This isn't need as "autocrop" is already used as the primary name for
the module (the name is defined in the Modules.am file).
> + var_Create( p_filter, "autocrop", VLC_VAR_INTEGER|VLC_VAR_ISCOMMAND );
This variable isn't used anywhere (at least not that I could see when
skiming over the patch).
Regards,
--
Antoine Cellerier
dionoea
More information about the vlc-devel
mailing list