[vlc-devel] [PATCH] autocrop video filter 2

Geoffroy Couprie geo.couprie at gmail.com
Tue Apr 15 23:25:03 CEST 2008


Le Tue, 15 Apr 2008 11:16:19 +0200,
Antoine Cellerier <dionoea at videolan.org> a écrit :

> A few more comments (I haven't had the opportunity to test the patch
> yet).
> 
> On Mon, Apr 14, 2008, Geoffroy Couprie wrote:
> > +    add_shortcut( "autocrop" );
> 
> This isn't need as "autocrop" is already used as the primary name for
> the module (the name is defined in the Modules.am file).
ok, I removed it
> 
> > +    var_Create( p_filter, "autocrop",
> > VLC_VAR_INTEGER|VLC_VAR_ISCOMMAND );
> 
> This variable isn't used anywhere (at least not that I could see when
> skiming over the patch).
removed too.

waiting for new bugs :)

-- 
Geoffroy Couprie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080415/49246731/attachment.sig>


More information about the vlc-devel mailing list