[vlc-devel] commit: Attach the sout object to libvlc ( Rafaël Carré )

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Sun, 20 Apr 2008 22:43:24 +0300,
Rémi Denis-Courmont <rdenis at simphalempin.com> a écrit :

> Le Sunday 20 April 2008 22:07:53 git version control, vous avez
> écrit :
> > vlc | branch: master | Rafaël Carré <funman at videolan.org> | Sun Apr
> > 20 21:08:35 2008 +0200| [42a0d047849f391a75432dfdf5d71523d6ec08c7]
> >
> > Attach the sout object to libvlc
> 
> This looks very wrong.
> 
> If there are multiple simultaenous inputs (VLM), sout instance should
> not interchange from one "input parent" (playlist or VLM media) to
> another. That's not conter-intuitive, illogical, and _not_
> thread-safe. Hence using libvlc is wrong, and using the playlist was
> right, as far as the input was spawned by the playlist.

I did not take VLM in consideration, maybe I'll look at the code later.
In the meantime if you want to revert, feel free, but please also
update the comments saying it should be attached to libvlc.

- -- 
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIC57VYWCeGMCv8Q8RAkHHAKCa/vWV1h8bqbZDzsRaMcium7uo3gCg10Ga
Ur30etdvJRKsc5usy8TjPoI=
=Rfww
-----END PGP SIGNATURE-----