[vlc-devel] commit: Fix crop/aspect ration and deinterlace menus in Qt. (solved by jpeg ) ( Rémi Duraffort )

[git version control]

vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Fri Aug 29 21:23:33 2008 +0200| [ba37f147f28110a53af263c76c3d0e09dcdd0aa5] | committer: Rémi Duraffort 

Fix crop/aspect ration and deinterlace menus in Qt. (solved by jpeg)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ba37f147f28110a53af263c76c3d0e09dcdd0aa5
---

 modules/gui/qt4/menus.cpp |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/modules/gui/qt4/menus.cpp b/modules/gui/qt4/menus.cpp
index f52eb8d..2ceeaa7 100644
--- a/modules/gui/qt4/menus.cpp
+++ b/modules/gui/qt4/menus.cpp
@@ -1177,7 +1177,6 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
         return VLC_EGENERIC;
     }
 
-#define NOTCOMMAND !( i_type & VLC_VAR_ISCOMMAND )
 #define CURVAL val_list.p_list->p_values[i]
 #define CURTEXT text_list.p_list->p_values[i].psz_string
 
@@ -1201,8 +1200,7 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
                 menutext = qfu( CURTEXT ? CURTEXT : another_val.psz_string );
                 CreateAndConnect( submenu, psz_var, menutext, "", ITEM_RADIO,
                         p_object->i_object_id, another_val, i_type,
-                        NOTCOMMAND && val.psz_string &&
-                        !strcmp( val.psz_string, CURVAL.psz_string ) );
+                        val.psz_string && !strcmp( val.psz_string, CURVAL.psz_string ) );
 
                 free( val.psz_string );
                 break;
@@ -1213,7 +1211,7 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
                 else menutext.sprintf( "%d", CURVAL.i_int );
                 CreateAndConnect( submenu, psz_var, menutext, "", ITEM_RADIO,
                         p_object->i_object_id, CURVAL, i_type,
-                        NOTCOMMAND && CURVAL.i_int == val.i_int );
+                        CURVAL.i_int == val.i_int );
                 break;
 
             case VLC_VAR_FLOAT:
@@ -1222,7 +1220,7 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
                 else menutext.sprintf( "%.2f", CURVAL.f_float );
                 CreateAndConnect( submenu, psz_var, menutext, "", ITEM_RADIO,
                         p_object->i_object_id, CURVAL, i_type,
-                        NOTCOMMAND && CURVAL.f_float == val.f_float );
+                        CURVAL.f_float == val.f_float );
                 break;
 
             default:
@@ -1234,7 +1232,6 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
     /* clean up everything */
     var_Change( p_object, psz_var, VLC_VAR_FREELIST, &val_list, &text_list );
 
-#undef NOTCOMMAND
 #undef CURVAL
 #undef CURTEXT
     return VLC_SUCCESS;