[vlc-devel] [PATCH 2/2] Add Apple AirTunes access output plugin

[Christophe Mutricy]

Hello


Some small comments:


2008/12/2 Michael Hanselmann <public at hansmi.ch>:
> diff --git a/configure.ac b/configure.ac
 > +  [  --enable-airtunes       AirTunes output plugin (default enabled)])
[...]
> +    AC_MSG_ERROR([libgcrypt support required for AirTunes plugin])

As it's default enabled, I'd rather have only a AC_MSG_WARN here


> +++ b/modules/access_output/airtunes.c
> +#include <string.h>
Already in vlc_common.h

> +#define AIRTUNES_USER_AGENT "iTunes/8.0.1 (Macintosh; N; Intel)"
I guess it's because the Airport Express wants this user-agent. Would
be nicer to be able to use "VLC VLC_Version"

>


-- 
Xtophe