[vlc-devel] [PATCH 2/2] Add Apple AirTunes access output plugin

[Michael Hanselmann]

2008/12/2 Christophe Mutricy <xtophe at chewa.net>:
> 2008/12/2 Michael Hanselmann <public at hansmi.ch>:
>> diff --git a/configure.ac b/configure.ac
>  > +  [  --enable-airtunes       AirTunes output plugin (default enabled)])
> [...]
>> +    AC_MSG_ERROR([libgcrypt support required for AirTunes plugin])
>
> As it's default enabled, I'd rather have only a AC_MSG_WARN here

Changed, see below.

>> +++ b/modules/access_output/airtunes.c
>> +#include <string.h>
> Already in vlc_common.h

Removed, thanks.

>> +#define AIRTUNES_USER_AGENT "iTunes/8.0.1 (Macintosh; N; Intel)"

> I guess it's because the Airport Express wants this user-agent. Would
> be nicer to be able to use "VLC VLC_Version"

It doesn't require it, I changed the code to use VLC's version instead
(e.g. "User-Agent: VLC 1.0.0-git").

Resending the whole patch of 44KB doesn't make sense if there might be
more changes. Below is an interdiff with the changes above. I can
resend the full patch if there are no more comments or someone wants
it.

diff --git a/configure.ac b/configure.ac
index 443f6f7..acae059 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5310,7 +5310,7 @@ if test "${enable_airtunes}" != "no"; then
     VLC_ADD_LIBS([access_output_airtunes], [${LIBGCRYPT_LIBS}])
     VLC_ADD_CFLAGS([access_output_airtunes], [${LIBGCRYPT_CFLAGS}])
   ], [
-    AC_MSG_ERROR([libgcrypt support required for AirTunes plugin])
+    AC_MSG_WARN([libgcrypt support required for AirTunes plugin])
   ])
 fi

diff --git a/modules/access_output/airtunes.c b/modules/access_output/airtunes.c
index c92ec9a..3ae98ed 100644
--- a/modules/access_output/airtunes.c
+++ b/modules/access_output/airtunes.c
@@ -29,7 +29,6 @@
 #endif

 #include <assert.h>
-#include <string.h>

 #include <gcrypt.h>

@@ -43,7 +42,7 @@
 #include <vlc_gcrypt.h>

 #define AIRTUNES_PORT 5000
-#define AIRTUNES_USER_AGENT "iTunes/8.0.1 (Macintosh; N; Intel)"
+#define AIRTUNES_USER_AGENT "VLC " VERSION


 static const char psz_airtunes_rsa_pubkey[] =


Regards,
Michael