[vlc-devel] [PATCH] -- vout_subpicture deadlock issue

[Rémi Denis-Courmont]

Le dimanche 7 décembre 2008 17:06:21 brezhoneg1, vous avez écrit :
> This patch corrects a bug which was made visible thanks to the following
> commit :
> http://git.videolan.org/?p=vlc.git;a=commit;h=4961a425c3d71ef817943b5326
> bb0d8ab4701575 (a vlc_assert_locked( &p_sys->lock ) had been added).
>
> the "SubFilterAllocationClean" function obviously does not hold a lock
> and yet set the b_lock parameter of SpuCleanChannel to true. This was
> tested in at least two situations:

> - see trac item https://trac.videolan.org/vlc/ticket/2281
> - setting a new media for a media_player (libvlc api) now raises this
> deadlock error too.
>
> Setting this parameter to false solves these two problems.
> (Yet, are there situations where it does hold the lock?, if so, deeper
> debugging work has to be done )

Seemingly not, but I really am not an expert on this stuff.

That being said, you should really the parameter completely as your patch 
makes it always false.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary