[vlc-devel] [PATCH] Fix snapshot chroma/size mismach bug

Laurent Aimar fenrir at via.ecp.fr
Fri Dec 12 22:33:58 CET 2008


On Fri, Dec 12, 2008, basos g wrote:
> Also there is size mismatch. Vout->fmt_out has the final video size
> that may be resized. This is not the initial picture size. This
> affects the snapshot size when snapshot-width and snapshot-height vars
> are zero (meaning snap the *original* size )
 For me it does not mean the original size, but the original *display* size, ie
after the aspect ratio has been applied.
 Using your patch, the snapshot has sometimes the wrong aspect ratio which is
not acceptable. (I have not investigated the reason).

> So  in the following example @ vout_Snapshot the local variable fmt_in
> that  *was* initialized with p_vout->fmt_out had a chroma RV32 while
> the real chroma taken from p_pic->format is I420. So when we feed this
> fmt_in to the encoder nasty snapshots are taken..
 Could you describe a way to reproduce it ?
 Using both I420 and RV24 output (xvideo and x11) with an I420 video source,
the snapshots are correctly taken for me.


More information about the vlc-devel mailing list