[vlc-devel] [PATCH] Fix snapshot chroma/size mismach bug

Laurent Aimar fenrir at via.ecp.fr
Fri Dec 12 22:54:33 CET 2008

On Fri, Dec 12, 2008, Laurent Aimar wrote:
> Hi,
> On Fri, Dec 12, 2008, basos g wrote:
> > Also there is size mismatch. Vout->fmt_out has the final video size
> > that may be resized. This is not the initial picture size. This
> > affects the snapshot size when snapshot-width and snapshot-height vars
> > are zero (meaning snap the *original* size )
>  For me it does not mean the original size, but the original *display* size, ie
> after the aspect ratio has been applied.
>  Using your patch, the snapshot has sometimes the wrong aspect ratio which is
> not acceptable. (I have not investigated the reason).
 Replying to myself, the picture format does not have the sar set but
i_aspect is.
 The attached patch fix the aspect ratio issue.

Anyway, when vout call vout_Snapshot both format (picture and vout) contain
the same video size (including any video output resize).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: vout-snapshot.patch
Type: text/x-diff
Size: 1035 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20081212/f5d6c3b0/attachment.patch>

More information about the vlc-devel mailing list