[vlc-devel] [PATCH] -- media_list and media_list_player(update2)

brezhoneg1 brezhoneg1 at yahoo.fr
Mon Dec 15 21:44:56 CET 2008

I realize this patch is not easy to review.

It seems to me the developer left an unfinished work as far as
media_list_player is concerned. Unlike most parts of the API which are
wholly operational, media_list_player was a first draft, and was
obviously never tested and never completed (events-wise)

Actually, if the developer is still around, he may be a great help to
discuss this patch. Especially as a media_list_player is a playlist
automation and locking/multiple access and so on are far from trivial in
such a work.

As for locking, I took hotkeys.c as an example of how to handle
cond_wait with vlc wrappers. But, please tell me what you find
suspicious. I may be wrong somewhere. 


> -----Message d'origine-----
> De : vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] De la part de Rémi Denis-Courmont
> Envoyé : lundi 15 décembre 2008 19:54
> À : vlc-devel at videolan.org
> Objet : Re: [vlc-devel] [PATCH] -- media_list and
> media_list_player(update2)
> Le vendredi 12 décembre 2008 02:57:25 brezhoneg1, vous avez écrit :
> > Please, find attached an updated version for a fix for media_list
> > media_list_player in libvlc api.
> Because it mixes cleanups, cosmetics, fixes and changes, it's
difficult to
> review this patch.
> Nevertheless, the way you're doing handling the thread lock and the
> condition
> variable looks extremely suspicious to me.
> --
> Rémi Denis-Courmont

More information about the vlc-devel mailing list