[vlc-devel] [PATCH] Download subtitles using OpenSubtitles.Org

[Rafaël Carré]

Le Tue, 15 Jan 2008 23:00:33 +0100,
Jean-Philippe André <jpeg at via.ecp.fr> a écrit :

> Hello,
> 
> I've started writing a patch for this trac entry :
> http://trac.videolan.org/vlc/ticket/899
> * This feature allows users download/upload subtitles directly from
> VLC.
> 
> It is not finished yet (really not !), but we have now a simple Qt
> interface that calls a C module which call a lua script. The lua
> script has to fetch a list of subtitles available for a movie name.
> 
> There are still some bugs and things left to do, but it should work
> fine.
> 
> In the next patch, it will be possible to choose different lua scripts
> (meaning different websites), and languages.
> 
> Screenshot :
> http://people.via.ecp.fr/~jpeg/VideoLAN/capture5.png
> 
> Patch is available on :
> http://people.via.ecp.fr/~jpeg/VideoLAN/patch1.diff
> 
> All comments welcome.
> 

+//     serverCombo->addItem( "OpenSubtitles.Org",
"opensubtitles.lua" );

What about having a function in each .lua which returns some infos ?
(name, website, ... ) and then run each script to find this info ?


+    languageCombo->addItem( qtr( "German" ), "DE" );
+    /* And so on... not hard-coded would maybe be better ? */

There might be an hard-coded list somewhere in vlc's code, will check.



+     QMessageBox::warning( this, qtr( "Not implemented yet !" ),
"caca" );

WoW what an interesting box title !!!!

+# define DOWNLOAD_SUBTITLES prout
great !


+#ifndef  _GNU_SOURCE
+#   define  _GNU_SOURCE
+#endif

This one is already taken care of, you can remove that part.



As pointed out some time before, we should not support websites which
do evidence of copyright violation.

Could you find some website which for example write their own subs ?

I think this would be an ultra-killer in the fansub community.

> Best Regards,
> 



-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080116/173dda9e/attachment.sig>