[vlc-devel] [PATCH] Download subtitles using OpenSubtitles.Org

[Jean-Philippe André]

Jean-Baptiste Kempf a écrit :
> On Wed, Jan 16, 2008, Pierre d'Herbemont wrote :
>> Woaw, That's a killer feature!
> +1

Cool.

> Keeping the opensubtitles part in a lua script is a really important
> feature, especially to avoid legal problems.
> 
> What happens if there is no script ?
> Do you plan to have a way to choose which script to use ?

Yes, actually, I had commented a little part of the code in the Qt
interface which allows people to choose their own scripts, or the
'builtin' ones (see « serverCombo » in help.cpp), because there is now
only one script.

If there is no script, I think the C module (subtitles.c) will fail and
return an error :

[00000360] lua interface debug: subtitles finder module loading...
[00000360] lua interface warning: Error loading script
share/luasubtitles/opensu
btitles.lua: cannot open share/luasubtitles/opensubtitles.lua: Aucun
fichier ou
répertoire de ce type
[00000360] qt4 interface debug: unable to load module

I will have to notice the user in the Qt interface, of course.

Best regards,

-- 
Jean-Philippe André
JPeg