[vlc-devel] [PATCH] VLC Linux mozilla plugin toolbar

[Jean-Paul Saman]

Frans van Veen wrote:
> I present you the Linux mozilla toolbar. Please apply the patch and 
> replay on this mail.

Patch applied with modifications from me.

> @Note
> - apply the patch

+ Cleanup the patch for coding style and readability,
+ Maximum number of 80 characters on a line
+ Fixed major memoryleak (image data was not released).

> - unzip image.zip in the mozilla folder

+ Image paths pointed to private build environment and was not suited 
for redristribution.
+ Solved crash caused by images in other location then standard 
expected. Added guards for not finding images.

> - edit the position of the image in the redraw function 
> "...XpmReadFileToImage...."
> - compile with "make"

It compiled fine, good work guys!

> - copy the mozilla/.libs/libvlcplugin.so file to /usr/lib/mozilla/plugins

This instruction doesn't work if there is no vlc installed on the system.

> @NEW
> - toolbar in Linux
> - Play, Pause, Stop, Fullscreen and Mute buttons
> - timeline, you can click on any place in the timeline and the movie 
> will jump to it
> - http://www.rtlgemist.nl support
> 
> @BUG
> - updating timeline not working well because callback function not 
> working "libvlc_event_attach......"
> - white line below the toolbar
> - play/pause toggle not working well because ticket #1065
> 
> We appreciate any input, Thanks.

Nicer images would make the toolbar really rock. Look at the small 
images from MacOS X (extras/MacOSX/Resources/) they are looking real nice.

> Frans van Veen and Jasper Alias

Gtz
Jean-Paul Saman.