[vlc-devel] commit: Remove dead code (CID #3) ( Rémi Denis-Courmont )

git version control git at videolan.org
Tue Jul 1 22:20:43 CEST 2008


vlc | branch: 0.8.6-bugfix | Rémi Denis-Courmont <rdenis at simphalempin.com> | Tue Jul  1 23:18:20 2008 +0300| [a50146e4e11d27950f591d158218355d4e151568]

Remove dead code (CID #3)

If (a < 0 || b < 0) is false, then (a >= 0 && b >= 0) is true,
which implies (a >= || b >= 0) is true as well.
And this was tagged as a FALSE positive!?!

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a50146e4e11d27950f591d158218355d4e151568
---

 modules/video_filter/osdmenu.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/modules/video_filter/osdmenu.c b/modules/video_filter/osdmenu.c
index 60688b4..36d34e9 100644
--- a/modules/video_filter/osdmenu.c
+++ b/modules/video_filter/osdmenu.c
@@ -207,17 +207,11 @@ static int CreateFilter ( vlc_object_t *p_this )
         p_filter->p_sys->p_menu->i_x = 0;
         p_filter->p_sys->p_menu->i_y = 0;
     }
-    else if( i_posx >= 0 || i_posy >= 0 )
+    else
     {
         p_filter->p_sys->p_menu->i_x = i_posx;
         p_filter->p_sys->p_menu->i_y = i_posy;
     }
-    else if( p_filter->p_sys->p_menu->i_x < 0 || p_filter->p_sys->p_menu->i_y < 0 )
-    {
-        p_filter->p_sys->b_absolute = VLC_FALSE;
-        p_filter->p_sys->p_menu->i_x = 0;
-        p_filter->p_sys->p_menu->i_y = 0;
-    }
 
     /* Set up p_filter */
     p_filter->p_sys->i_last_date = mdate();




More information about the vlc-devel mailing list