[vlc-devel] commit: Remove dead code (CID #3) ( Rémi Denis-Courmont )

git version control git at videolan.org
Tue Jul 1 22:22:05 CEST 2008


vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Tue Jul  1 23:18:20 2008 +0300| [2ab18523421ccdb4069d1e627d0aa4e7a71d37a0]

Remove dead code (CID #3)

If (a < 0 || b < 0) is false, then (a >= 0 && b >= 0) is true,
which implies (a >= || b >= 0) is true as well.
And this was tagged as a FALSE positive!?!

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2ab18523421ccdb4069d1e627d0aa4e7a71d37a0
---

 modules/video_filter/osdmenu.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/modules/video_filter/osdmenu.c b/modules/video_filter/osdmenu.c
index 105089e..28818f3 100644
--- a/modules/video_filter/osdmenu.c
+++ b/modules/video_filter/osdmenu.c
@@ -228,18 +228,11 @@ static int CreateFilter ( vlc_object_t *p_this )
         p_sys->p_menu->i_x = 0;
         p_sys->p_menu->i_y = 0;
     }
-    else if( (p_sys->i_x >= 0) || (p_sys->i_y >= 0) )
+    else
     {
         p_sys->p_menu->i_x = p_sys->i_x;
         p_sys->p_menu->i_y = p_sys->i_y;
     }
-    else if( (p_sys->p_menu->i_x < 0) ||
-             (p_sys->p_menu->i_y < 0) )
-    {
-        p_sys->b_absolute = false;
-        p_sys->p_menu->i_x = 0;
-        p_sys->p_menu->i_y = 0;
-    }
 
     /* Set up p_filter */
     p_sys->i_last_date = mdate();




More information about the vlc-devel mailing list