[vlc-devel] Request for removal of commit rights
Bill C. Riemers
briemers at redhat.com
Thu Jul 10 19:00:34 CEST 2008
It seems to me we could avoid many problems, if developers were to use
branches more frequently.
There are two primary reasons to commit code:
1. A developer has something that will really fix or improve things.
2. A developer has code they want to share with others for comments and
So long as everything is committed to the trunk, commits can only done
in case #1. Which is really a shame, since part of collaboration is
reviewing other peoples code and providing necessary feedback.
So my suggestion would be anyone submitting code, that is not fairly
certain it meets criteria #1 should use a branch. Once the code has
been commented on improved so it meets criteria #1, then it can be moved
onto the trunk.
Rémi Denis-Courmont wrote:
> As far as I am concerned, the conditions are not met to ensure proper code
> quality. I have spent hundreds of hours tracking down bugs, some added by me,
> some normal regressions, but many added by unreviewed reckless commits. And I
> got insulted when I dared complain about committed hacks (still waiting for
> excuses, but I don't really expect them ever).
> All I wanted was to put an end to this. It is obvious that this will go on as
> badly as ever, if all developpers support keeping the current mode of
> operation. If that is the case, I am not going to waste any more of my free
> time trying to fix things. Working on new features in my own tree is much
> more interesting. Effective now, I stop will not be doing any bug fixing
> Have a lot of fun fixing bugs on my behalf.
More information about the vlc-devel