[vlc-devel] [PATCH] [codec/schroedinger] Fix potential dereference of already free()d pointer

David Flynn davidf+nntp at woaf.net
Fri Jul 11 20:04:26 CEST 2008


From: David Flynn <davidf at rd.bbc.co.uk>

In some error cases p_block will have been freed before p_block is
dereferenced.
---
 modules/codec/schroedinger.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/modules/codec/schroedinger.c b/modules/codec/schroedinger.c
index adf8017..de41b73 100644
--- a/modules/codec/schroedinger.c
+++ b/modules/codec/schroedinger.c
@@ -469,11 +469,6 @@ static picture_t *DecodeBlock( decoder_t *p_dec, block_t **pp_block )
             if( b_bail )
                 break;
         }
-
-        if( (i_bufused > 0) && (i_bufused < p_block->i_buffer) )
-            msg_Err( p_dec, "not submitted everything in p_buffer");
-
-
     } while( 0 );
 
     while( 1 )
-- 
1.5.5





More information about the vlc-devel mailing list