[vlc-devel] commit: Specifying any CFLAGS clobbers any that liboil' s configure script would (Jonathan Rosser )

[git version control]

vlc | branch: master | Jonathan Rosser <jrosser at rd.bbc.co.uk> | Tue Jul 15 12:41:32 2008 +0100| [9edde94fde60f2def3e516e04273982ef99c30b7]

Specifying any CFLAGS clobbers any that liboil's configure script would
naturally choose.  With only an effective -O0 gcc 4.0.1 doesn't produce
code as intented for copy_u8_altivec, causing liboil to fail at runtime.

Summary, liboil really needs -O2 (always).

Signed-off-by: David Flynn <davidf at rd.bbc.co.uk>
Signed-off-by: Felix Paul Kühne <fkuehne at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9edde94fde60f2def3e516e04273982ef99c30b7
---

 extras/contrib/src/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/extras/contrib/src/Makefile b/extras/contrib/src/Makefile
index 4e463ca..d174b42 100644
--- a/extras/contrib/src/Makefile
+++ b/extras/contrib/src/Makefile
@@ -2428,7 +2428,7 @@ liboil: liboil-$(OIL_VERSION).tar.gz
 	patch -d liboil -p1 < Patches/liboil-noshared.patch
 
 .liboil: liboil
-	(cd $<; $(HOSTCC) ./configure $(HOSTCONF) --prefix=$(PREFIX) && make && make install)
+	(cd $<; $(HOSTCC) ./configure $(HOSTCONF) --prefix=$(PREFIX) CFLAGS="$(CFLAGS) -O2" && make && make install)
 	touch $@
 
 CLEAN_FILE += .liboil