[vlc-devel] commit: Removed some useless dgb msgs and added some more useful localised error msgs ( Felix Paul Kühne )

[Pierre d'Herbemont]

On Jul 20, 2008, at 12:17 AM, Felix Paul Kühne wrote:

>
> Am 19.07.2008 um 21:12 schrieb Pierre d'Herbemont:
>
>>
>> On Jul 19, 2008, at 8:36 PM, git version control wrote:
>>> @@ -755,6 +758,9 @@ static VLCSimplePrefs *_o_sharedInstance = nil;
>>>       if( i != 0 )
>>>       {
>>>           msg_Err( p_intf, "An error occurred while saving the
>>> Audio settings using SimplePrefs (%i)", i );
>>> +            intf_UserFatal( p_intf, false, _("Audio Settings not
>>> saved"),
>>> +                        _("An error occured while saving your
>>> settings via SimplePrefs (%i)."), i );
>>> +
>>
>> Given how interaction is race prone and crashy, I am wondering myself
>> if using it is a good idea... Why not NSRunAlertPanel directly?
>
> Because the interaction code adds this non-blocking alert to the
> "Errors and Warnings" panel, which is more appropriate here IMO.

Well, we don't agree here. the "Errors and Warning" panel is not  
compliant to the Mac OS interface guideline. We shouldn't use it when  
we can.

> BTW.
> the interaction code works nicely for me and doesn't lock up the
> interface, so I'd rather like to keep it this way.

Well. that doesn't mean it's not prone to races ;)

> Anyway, these error
> messages should never show up, so I don't really care.

Good point. They should be merged in just one error.

Pierre.