[vlc-devel] [PATCH]Improved nuv demuxer and new rtjpeg decoder

[Rémi Denis-Courmont]

	Hello,

Le mardi 22 juillet 2008 17:09:45 Gertjan Van Droogenbroeck, vous avez écrit :
> Because I did not find a player that supported the MythTV .nuv files
> with RTjpeg encoding on Windows, I tried to see what was necessary to
> get those files working in VLC.

Some problems with the nuv patch:

Please do not use packed structures unless there is no other way, as this is 
not portable. You anyway have to do byte endianness conversion. NEVER EVER 
use non-fixed integers inside packed structures.

There is no need to use vlc_memcpy() for a small fixed size header. The 
function call overhead might be worse than using plain non-optimized 
memcpy(). You should probably use block_Realloc() instead of 
block_Alloc()+memcpy() anyway.

The format string for int64_t is "%"PRI64d, not "%lld". The format string for 
size_t (including sizeof()) is "%zu", not "%d".

-- 
Rémi Denis-Courmont
http://www.remlab.net/