[vlc-devel] [PATCH]Improved nuv demuxer and new rtjpeg decoder

Gertjan Van Droogenbroeck gertjanvd at gmail.com
Wed Jul 23 11:41:41 CEST 2008


On Tue, Jul 22, 2008 at 9:56 PM, Rémi Denis-Courmont
<rdenis at simphalempin.com> wrote:
> Some problems with the nuv patch:
> Please do not use packed structures unless there is no other way, as this is
> not portable. You anyway have to do byte endianness conversion. NEVER EVER
> use non-fixed integers inside packed structures.
It no longer uses the packed structures. It now uses fixed offsets.

> There is no need to use vlc_memcpy() for a small fixed size header. The
> function call overhead might be worse than using plain non-optimized
> memcpy(). You should probably use block_Realloc() instead of
> block_Alloc()+memcpy() anyway.
I didn't know block_Realloc could be used for that, I thought it
worked like realloc. It now uses block_Realloc()+memcpy().

> The format string for int64_t is "%"PRI64d, not "%lld". The format string for
> size_t (including sizeof()) is "%zu", not "%d".
The format strings are changed, I also replaced it in the code that
was already there.

I also fixed a bug with the GET_LENGTH calculations in unseekable streams.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Improved-nuv-demuxer.patch
Type: text/x-patch
Size: 21308 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080723/1ae0e2c4/attachment.bin>

More information about the vlc-devel mailing list