[vlc-devel] commit: Use the signal interface and fix signal handling ( Rémi Denis-Courmont )

bl4 bl4 at playker.info
Wed Jun 4 23:06:49 CEST 2008

Rémi Denis-Courmont wrote:
> Le lundi 2 juin 2008 23:14:27 bl4, vous avez écrit :
>> I'm afraid this commit broke the vlc gui in my case. When I pass a
>> filename on the command line, vlc starts playing, but the status bar is
>> empty, the title bar is unchanged, the progress bar doesn't move and the
>> Pause/Play button doesn't work. Everything goes back to normal when I
>> stop and play again. Everything is fine when I use Media | Open File
>> menu to open a file.
> I cannot reproduce the problem, but this should be fixed now anyway.

Well, the problem still occurs. One of your commits removed b_play 
property and all the code that depended on it. It means that 
playlist_Control( THEPL, PLAYLIST_PLAY, false ) in qt4.cpp is no longer 
executed (or something similar in other gui modules, I only tested qt). 
Instead, the playlist is started in vlc.c with libvlc_playlist_play 
(vlc, -1, 0, NULL, NULL).

This change causes exactly the same problem with my gui, I can't explain 
why. I fixed it by restoring the code in qt4.cpp, making it work without 
b_play property and removing the code for starting playlist in vlc.c. 
But the other gui modules would have to be changed too and it looks 
pointless because it's not what removing b_play was for. When I have 
some time I'll try to find out why it doesn't work for me.


More information about the vlc-devel mailing list