[vlc-devel] [PATCH] Add Scaletempo audio filter

[Pierre d'Herbemont]

On Jun 17, 2008, at 1:48 AM, Rov Juvano wrote:

> On Mon, Jun 16, 2008 at 09:40:35PM +0300, Rémi Denis-Courmont wrote:
>> Le lundi 16 juin 2008 08:37:21 Rov Juvano, vous avez écrit :
>>> Scaletempo maintains the audio pitch when playback rate != 1.0 (i.e.
>>> no chipmunk effect).  This fixes the pitch scaling caused by using  
>>> the
>>> resampler to handle playback rate.
>>
>> While the feature sounds (ahaha) cool, I am not very keen on  
>> changing the
>> audio output code (and breaking the ABI for that) during the feature
>> freeze :/
>
> So, you're telling me you'd rather stick it into to git for
> who knows how long because you're in an earlier timezone?
> Darn my insistence on one last test.  That last rebase turned
> into hours of debugging and bisecting the upstream commits
> that broke my test apps.
>
>
> Anyway, I announced over a week ago I was adding this.  Was
> that not enough?  Even so, this feature was started over a
> year ago by Laurent Aimar.  Are you saying you'd rather leave
> it half done for 0.9.0?

If it's a bug fix then ;)

Seriously, we could open up a branch with pending patches, so that we  
could cherry-pick them at some point, and don't forget it.

What do you think,

Pierre.