[vlc-devel] [RFC][PATCH] fix mozplug toolbar

[Anthony Loiseau]

Hi all,

As discussed on the IRC,
Mozilla-plugin ODS-toolbar (X11) seems to not work.

A while ago, I have managed to patch it but had not found the time to
make my patches clean, so did't propose it (part of patch 0002)
As asked, here there are (I've done a pull rebase before).


I have no time to test it, sorry. The reason why I add RFC as subject.
I find them not clean because:

 - one patch fix 2 things (need a rebase -i to be cleaner)
 - timeline didn't worked, iirc (but play/pause worked)


I don't remember if last patch (play/pause) was very usefull, you should
test with and without. It was about pausing after the end of the video
and pausing several times.
The flag is_playing did not come back to "play" when quitting pause
calling libvlc_play, so I had thought to quit it with another
libvlc_pause (this is a toggle function).


Hope I am clear enough,
good luck with those patches and sorry for the lack of time to send them
just clean.
_anthony (thannoy)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-typo-80-char-per-line-few-comments-added.patch
Type: application/mbox
Size: 4735 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080617/797a1c6f/attachment.mbox>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-toolbar-bool-RW-property-for-the-JS-API-fix-t.patch
Type: application/mbox
Size: 20420 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080617/797a1c6f/attachment-0001.mbox>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-fix-moz-toolbar-play-pause.patch
Type: application/mbox
Size: 1670 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080617/797a1c6f/attachment-0002.mbox>