[vlc-devel] [RFC][PATCH] fix mozplug toolbar
jpsaman at videolan.org
Tue Jun 17 22:43:14 CEST 2008
Anthony Loiseau wrote:
> As discussed on the IRC,
> Mozilla-plugin ODS-toolbar (X11) seems to not work.
That is my fault I broke it while trying to rewrite it. The original
codes was not ok so I set out to rewrite it, but due to lack of time it
> A while ago, I have managed to patch it but had not found the time to
> make my patches clean, so did't propose it (part of patch 0002)
> As asked, here there are (I've done a pull rebase before).
I applied 0002 after some rewrite, but the approach seemed ok
> I have no time to test it, sorry. The reason why I add RFC as subject.
> I find them not clean because:
> - one patch fix 2 things (need a rebase -i to be cleaner)
> - timeline didn't worked, iirc (but play/pause worked)
Timeline never worked in the orignal patch.
> I don't remember if last patch (play/pause) was very usefull, you should
> test with and without. It was about pausing after the end of the video
> and pausing several times.
Indeed 0003 is not usefull.
> The flag is_playing did not come back to "play" when quitting pause
> calling libvlc_play, so I had thought to quit it with another
> libvlc_pause (this is a toggle function).
> Hope I am clear enough,
> good luck with those patches and sorry for the lack of time to send them
> just clean.
> _anthony (thannoy)
Thanks for sending these patches.
More information about the vlc-devel