[vlc-devel] [PATCH 2/3] Introduce new codec module to decode dirac video via libschroedinger

[Rémi Denis-Courmont]

Le vendredi 27 juin 2008 19:17:16 Jonathan Rosser, vous avez écrit :
>  dnl
> +dnl  schroedinger decoder plugin (for dirac format video)
> +dnl
> +AC_ARG_ENABLE(schroedinger,
> +[  --enable-schroedinger   high performance dirac codec (default
> enabled)]) +if test "${enable_schroedinger}" != "no"; then
> +  PKG_CHECK_MODULES(SCHROEDINGER,[schroedinger-1.0 >= 1.0], [
> +      VLC_ADD_PLUGIN([schroedinger])
> +      VLC_ADD_CFLAGS([schroedinger],[$SCHROEDINGER_CFLAGS])
> +      VLC_ADD_LIBS([schroedinger],[$SCHROEDINGER_LIBS]) ],[
> +      AC_MSG_ERROR([libschroedinger doesn't appear to be installed on you
> system.]) +  ])
> +fi

If I am not mistaken, this will break if Schroedinger is not present. I would 
rather have autodetection _unless_ there is an explicit --disable 
or --enable.

We can have the (political as much as technical, I'm afraid) debate 
regarding "strongly incitating" packagers to ship VLC with the Dirac 
decoder... But, probably not in version 0.9.0.

-- 
Rémi Denis-Courmont
http://www.remlab.net/