[vlc-devel] [PATCH 2/3] Introduce new codec module to decode dirac video via libschroedinger

David Flynn davidf+nntp at woaf.net
Sun Jun 29 02:01:15 CEST 2008


On 2008-06-28, Rémi Denis-Courmont <rdenis at simphalempin.com> wrote:
> If I am not mistaken, this will break if Schroedinger is not present. I would 
> rather have autodetection _unless_ there is an explicit --disable 
> or --enable.

Oops, it seems the suggestion to use png as a templated example didn't
work so well.  How is this for measure? (Tested in all modes and seems to work)

diff --git a/configure.ac b/configure.ac
index 3c84172..4021ec7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3590,14 +3590,16 @@ dnl
 dnl  schroedinger decoder plugin (for dirac format video)
 dnl
 AC_ARG_ENABLE(schroedinger,
-[  --enable-schroedinger   high performance dirac codec (default enabled)])
+[  --disable-schroedinger   high performance dirac codec (default enabled)])
 if test "${enable_schroedinger}" != "no"; then
   PKG_CHECK_MODULES(SCHROEDINGER,[schroedinger-1.0 >= 1.0], [
       VLC_ADD_PLUGIN([schroedinger])
       VLC_ADD_CFLAGS([schroedinger],[$SCHROEDINGER_CFLAGS])
-      VLC_ADD_LIBS([schroedinger],[$SCHROEDINGER_LIBS]) ],[
-      AC_MSG_ERROR([libschroedinger doesn't appear to be installed on you system.])
-  ])
+      VLC_ADD_LIBS([schroedinger],[$SCHROEDINGER_LIBS]) ], [
+        AS_IF([test "x${enable_schroedinger}" != "x"], [
+          AC_MSG_ERROR([${SCHROEDINGER_PKG_ERRORS}])
+        ])
+])
 fi
 
 dnl




More information about the vlc-devel mailing list