[vlc-devel] commit: Don't try to use 10.5-only threading features on a 10.4u target. Fixes #1614 on OS X. ( Felix Paul Kühne )

Pierre d'Herbemont pdherbemont at free.fr
Sun Jun 29 18:48:19 CEST 2008


Quoting git version control <git at videolan.org>:

> -    manageThread = [[NSThread alloc] initWithTarget:self
> selector:@selector(manage)
> -                                     object: nil];
> +    [NSThread detachNewThreadSelector: @selector(manage)
> +                             toTarget: self withObject: nil];
>

> -    [manageThread cancel];
> -    [manageThread release];
> -

This is a bad idea to remove that. We'll end up in crashes or assert failure
when VLC exits.

Hopefully 10.4 has something to kill a NSThread. I cant check from here though.

Pierre.



More information about the vlc-devel mailing list