[vlc-devel] commit: Don't try to use 10.5-only threading features on a 10.4u target. Fixes #1614 on OS X. ( Felix Paul Kühne )

[Felix Paul Kühne]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On 29.06.2008, at 18:48, Pierre d'Herbemont wrote:

> This is a bad idea to remove that. We'll end up in crashes or assert  
> failure
> when VLC exits.
I know. Your approach is way better, although it was missing  
[manageThread start] which is it wasn't working correctly.  
Regrettably, it's 10.5 only.

> Hopefully 10.4 has something to kill a NSThread. I cant check from  
> here though.
No, it doesn't because you don't get a reference to the detached  
thread as you are forced to use the class method  
"detachNewThreadSelector...". The documentation explicitly states that  
there is no work-around.
Since we did use this function for years with no major crashes on  
exit, I hope this will continue work somehow until we drop 10.4u,  
which we definitely don't want to for 0.9.0 IMO.

Best,

Felix


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)

iEYEARECAAYFAkhnyxIACgkQtUgezvXAcGOq/gCeI0o5wX7lfh08sCEBpwe6R5VD
l6kAnj7yQfKxRQ7EYmyMSIh5nAbycZBm
=HzNa
-----END PGP SIGNATURE-----