[vlc-devel] [PATCH] workaround broken filesystem

Rémi Denis-Courmont rem at videolan.org
Sun Mar 9 19:05:13 CET 2008


Le Sunday 09 March 2008 14:16:11 Rafaël Carré, vous avez écrit :
> I've trouble accessing the files located on my hfsplus (OSX) partition.
> directory access is used instead of file to open *files*
>
> The bug is that opendir() succeeds opening files on this mounted
> filesystem (i.e. returns a valid DIR* pointer).

That's going to break so many other applications, is it not? Then, I wonder if 
it makes sense to have an ugly work-around in VLC in the first place.

In any case the proper way to check this, is through dirfd() then fstat(), 
rather than stat(). And I think we already do these calls, so it should be 
piece of cake to add S_ISDIR there.

-- 
Rémi Denis-Courmont



More information about the vlc-devel mailing list