[vlc-devel] [PATCH] workaround broken filesystem

[Rafaël Carré]

On Sun, 2008-03-09 at 20:05 +0200, Rémi Denis-Courmont wrote:
> Le Sunday 09 March 2008 14:16:11 Rafaël Carré, vous avez écrit :
> > I've trouble accessing the files located on my hfsplus (OSX) partition.
> > directory access is used instead of file to open *files*
> >
> > The bug is that opendir() succeeds opening files on this mounted
> > filesystem (i.e. returns a valid DIR* pointer).
> 
> That's going to break so many other applications, is it not? Then, I wonder if 
> it makes sense to have an ugly work-around in VLC in the first place.

I don't think an extra check would break anything, but I agree that VLC
is not really a place to work around linux kernel bugs.

> In any case the proper way to check this, is through dirfd() then fstat(), 
> rather than stat(). And I think we already do these calls, so it should be 
> piece of cake to add S_ISDIR there.

These calls are not in OpenDir() which is used to probe the demuxer (aka
see if it can handle the path given to vlc)
-- 
Rafaël Carré <funman at videolan.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080309/58955c60/attachment.sig>