[vlc-devel] commit: i_verbose has been privatized ( Rafaël Carré )

Rémi Denis-Courmont rdenis at simphalempin.com
Mon May 5 17:06:33 CEST 2008

Le Monday 05 May 2008 14:56:19 Dominique Leuenberger, vous avez écrit :
> Lately I see more and more 'micro patches' that submit something but
> only half of the trueth. Then may such small fix ups are comited.
> Wouldn't it be a nice and noble goal to have such changes all
> incorporated in the actual fix? In my opinion, the git tree should
> stay compilable in any revision possible that can be checked out.

I take it you have not computed the ratio of compilation-breaking commits to 
that of total commits over the last week end.

> Of course patches would be a bit larger, but they would be self
> contained and complete.

Same comment.

Besides, I strongly disagree. Smaller commits are easier to describe (and 
understand for reviewers), and easier to bisect and revert as appropriate.

Rémi Denis-Courmont

More information about the vlc-devel mailing list