[vlc-devel] commit: Detach the children at object destruction ( Rafaël Carré )

Remi Denis-Courmont rdenis at simphalempin.com
Fri May 16 15:10:30 CEST 2008


On Fri, 16 May 2008 14:19:36 +0200, "Rafaël Carré" <funman at videolan.org>
wrote:
> 2008/5/16 Remi Denis-Courmont <rdenis at simphalempin.com>:
>>
>> On Fri, 16 May 2008 14:02:39 +0200 (CEST), git at videolan.org (git version
>> control) wrote:
>>> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Fri May
> 16
>>> 14:03:48 2008 +0200| [e5b3d194ffa17dcbf57e69ebf83c3730e8938932]
>>>
>>> Detach the children at object destruction
>>
>> This is as wrong as the previous commit.
> 
> How ?

1/ it breaks the later children debugging in vlc_object_destroy
2/ it's O(i_children*i_children), since vlc_object_detach is O(i_children).
   The original code was O(i_children)

-- 
Rémi Denis-Courmont
http://www.remlab.net




More information about the vlc-devel mailing list