[vlc-devel] commit: Detach the children at object destruction ( Rafaël Carré )

Rémi Denis-Courmont rdenis at simphalempin.com
Sat May 17 12:00:01 CEST 2008

Le Friday 16 May 2008 15:02:39 git version control, vous avez écrit :
> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Fri May 16
> 14:03:48 2008 +0200| [e5b3d194ffa17dcbf57e69ebf83c3730e8938932]
> Detach the children at object destruction

Oops, hmm well. Now I understand what you're solving. This patch was actually 
kinda correct (albeit inefficient), sorry. It's a matter of choice though. 
I'd personnaly rather not have any dead object left over in the structure 
anyhow, so I prefer to detach children at destruction (as this patch did) 
rather than have the big refcount hack in FindObject.

If we go that route, the children leak code probably needs to be removed. I 
expect it will never detect any error anymore.

N.B.: I still believe the "cleanup" patch was totally wrong, however tempting 
the cleanup may seem.

Rémi Denis-Courmont

More information about the vlc-devel mailing list