[vlc-devel] commit: Spu pause support. (Laurent Aimar )

[Derk-Jan Hartman]

Laurent,

CID 249, unreachable code:

if( !b_paused && p_subpic->pf_update_regions )
blocks
if( p_subpic->b_subtitle && b_paused && p_sys->i_last_render_date > 0 )

I think you will know best how to handle this?

DJ

> @@ -394,13 +398,18 @@ void spu_RenderSubpictures( spu_t *p_spu,
>
>         if( !b_paused && p_subpic->pf_update_regions )
>         {
> +            mtime_t i_render_date;
>             video_format_t fmt_org = *p_fmt_dst;
>             fmt_org.i_width =
>             fmt_org.i_visible_width = i_source_video_width;
>             fmt_org.i_height =
>             fmt_org.i_visible_height = i_source_video_height;
>
> -            p_subpic->pf_update_regions( p_spu, p_subpic, &fmt_org,  
> i_current_date );
> +            i_render_date = i_current_date;
> +            if( p_subpic->b_subtitle && b_paused && p_sys- 
> >i_last_render_date > 0 )
> +                i_render_date = p_sys->i_last_render_date;
> +
> +            p_subpic->pf_update_regions( p_spu, p_subpic, &fmt_org,  
> i_render_date );
>         }
>
>         /* */