[vlc-devel] commit: Revert "transcode: try to fix audio resampling (fix #1862)" ( Ilkka Ollakka )

[Rémi Denis-Courmont]

On Tue,  2 Sep 2008 12:46:59 +0200 (CEST), git at videolan.org (git version
control) wrote:
> Revert "transcode: try to fix audio resampling (fix #1862)"
> 
> This reverts commit 867a815956401f12780892c3432d915ff470ff4e.
> 
> That commit basicly just disabled resampling

Please. Stop these hacks. It will only break some combinations to fix
others. Instead, set _*CONSISTENT*_ filter parameters, and fix the
_*filters*_ not transcode. Namely this commit seems completely
inconsistent.

IIRC, this revert will bring back out of bound access in the trivial
resampler. Also it setting the audio rate to totally inconsistent,
considering the other paremeters that are set in the same place.

> diff --git a/modules/stream_out/transcode.c
> b/modules/stream_out/transcode.c
> index 620a109..9a6490d 100644
> --- a/modules/stream_out/transcode.c
> +++ b/modules/stream_out/transcode.c
> @@ -1146,7 +1146,7 @@ static int transcode_audio_new( sout_stream_t
> *p_stream,
>                      id->p_decoder->fmt_out.i_codec );
>      id->p_encoder->fmt_in.audio.i_format =
> id->p_decoder->fmt_out.i_codec;
> 
> -    id->p_encoder->fmt_in.audio.i_rate =
> fmt_last.audio.i_rate;//id->p_encoder->fmt_out.audio.i_rate;
> +    id->p_encoder->fmt_in.audio.i_rate =
> id->p_encoder->fmt_out.audio.i_rate;
>      id->p_encoder->fmt_in.audio.i_physical_channels =
>          id->p_encoder->fmt_out.audio.i_physical_channels;
>      id->p_encoder->fmt_in.audio.i_original_channels =

-- 
Rémi Denis-Courmont