[vlc-devel] commit: Revert "transcode: try to fix audio resampling (fix #1862)" ( Ilkka Ollakka )

[Ilkka Ollakka]

On ti  2. syyskuuta 2008 13:32:00, Rémi Denis-Courmont wrote:
> 
> On Tue,  2 Sep 2008 12:46:59 +0200 (CEST), git at videolan.org (git version
> control) wrote:
> > Revert "transcode: try to fix audio resampling (fix #1862)"
> > 
> > This reverts commit 867a815956401f12780892c3432d915ff470ff4e.
> > 
> > That commit basicly just disabled resampling
> 
> Please. Stop these hacks. It will only break some combinations to fix
> others. Instead, set _*CONSISTENT*_ filter parameters, and fix the
> _*filters*_ not transcode. Namely this commit seems completely
> inconsistent.
 
 That commit that I reverted setted samplerates so, that transcode
 didn't put any resampler in action, so it just hided the real problem
 and broke resampling.

> IIRC, this revert will bring back out of bound access in the trivial
> resampler. Also it setting the audio rate to totally inconsistent,

 Yes, I think you could be right on that one, but doesn't that mean that
 trivial resampler should be checked then instead of disabling
 resampling alltogether? 


-- 
Ilkka Ollakka
It is Mr. Mellon's credo that $200,000,000 can do no wrong.  Our
offense consists in doubting it.
		-- Justice Robert H. Jackson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080902/0e0a4418/attachment.sig>