[vlc-devel] vlc: svn commit r24208 (jpsaman)

Derk-Jan Hartman hartman at videolan.org
Tue Sep 9 02:46:02 CEST 2008


On 9 jan 2008, at 20:50, Subversion daemon wrote:
> r24208 | jpsaman | 2008-01-09 20:50:03 +0100 (Wed, 09 Jan 2008) | 2  
> lines
> Changed paths:
>   M /branches/0.8.6-bugfix/THANKS
>   M /branches/0.8.6-bugfix/modules/mux/mp4.c
>
> Patch by Christopher Key. Attached is a patch that fixes a long  
> standing problem whereby video encoded with vlc using x264 cannot be  
> made playable on an iPhone. The issue was traced to the H264 profile  
> value being incorrectly set, which this patch addresses.  Looking at  
> the code, the trunk appears to have had a complete rewrite and  
> should be unaffected, but this may be useful for a 0.8.6e release.
>
>> http://trac.videolan.org/vlc/changeset/24208

You made an error here jpsaman....
http://git.videolan.org/?p=vlc.git;a=commitdiff;h=96064b6c6af55d4fb3a9fb3f1328061bd2f33afa

You left one line in place that should have been removed. Ergo 0.8.6i  
is still broken.

DJ




More information about the vlc-devel mailing list